| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve GetConfigOptionValues function |
| Date: | 2023-01-18 16:34:31 |
| Message-ID: | CALj2ACXZMOGEtjk+eh0Zeiz=46ETVkr0koYAjWt8SoJUJJUe9g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 18, 2023 at 9:44 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Possibly a better answer is to refactor into separate functions,
> along the lines of
>
> static bool
> ConfigOptionIsShowable(struct config_generic *conf)
>
> static void
> GetConfigOptionValues(struct config_generic *conf, const char **values)
+1 and ConfigOptionIsShowable() function can replace explicit showable
checks in two other places too.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vik Fearing | 2023-01-18 17:01:34 | Re: ANY_VALUE aggregate |
| Previous Message | Tomas Vondra | 2023-01-18 16:29:43 | Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements |