Re: pg_waldump stucks with options --follow or -f and --stats or -z

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_waldump stucks with options --follow or -f and --stats or -z
Date: 2021-11-17 16:54:18
Message-ID: CALj2ACXHa63so=t95_pVRW-UpKeKjPDG9T6zSvSoYANgudYcTA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 17, 2021 at 7:49 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> At the same time, we could also just let things as they are. --follow
> and --stats being specified together is what the user looked for, so
> they get what they wanted.

I think the existing way of pg_waldump getting stuck with the
combination of options "-s/-f/-z" and "-s/-e/-f/-z" doesn't look good
for an end user. In the simplest way, the pg_waldump can just emit an
error for these combinations. That shouldn't a big problem as we do
emit errors for a lot of mutually exclusive combination of options
other SQL statements/commands.

Regards,
Bharath Rupireddy.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-11-17 17:05:53 Re: Granting SET and ALTER SYSTE privileges for GUCs
Previous Message Mark Dilger 2021-11-17 16:07:04 Re: Granting SET and ALTER SYSTE privileges for GUCs