| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Subject: | Re: parallel autovacuum: Propagate track_cost_delay_timing to parallel workers |
| Date: | 2026-09-29 13:26:17 |
| Message-ID: | CALj2ACX3H_5ZdA9jbn7yKdpNPXOxFnD-J-EQ-=HoDEoZFaJ0Mw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Mon, Sep 28, 2026 at 9:12 PM Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> wrote:
>
> > That said, I checked track_wal_io_timing and it reports the
> > accumulated timing even after the GUC is turned off, see
> > pgstat_count_io_op_time(). IIUC, what matters there is whether timing
> > was on when the start time was captured, not what it is at reporting
> > time. Looking at that, I would prefer reporting the remaining
> > accumulated time here too to make it complete.
>
> Fair enough.
>
> I guess this also fits better with the existing comment.
>
> ```
> /* Report any remaining cost-based vacuum delay time */
> ```
>
> > Also, +1 to rename track_delay_timing to GUC name.
>
> Done.
>
> v2 attached.
Thanks. v2 looks good to me. pgindent and tests are happy, and the
same patch applies on PG19 as well.
One nit, please feel free to ignore it. VacuumUpdateCosts() prints
yes/no for booleans, so on/off here could match that for consistency.
AFAICS, there is no hard rule, and I am fine with it as is.
--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2026-09-29 13:38:48 | Re: BUG #19597: getQuadrant: impossible case is reachable |
| Previous Message | Peter Eisentraut | 2026-09-29 13:07:15 | Re: Credits For v19 |