| From: | Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Subject: | Re: parallel autovacuum: Propagate track_cost_delay_timing to parallel workers |
| Date: | 2026-09-29 04:12:40 |
| Message-ID: | CAN12+YKdOimN3dXwU7AffJ1R-4No62vQfNBZvvcofbkO_2BAGQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> That said, I checked track_wal_io_timing and it reports the
> accumulated timing even after the GUC is turned off, see
> pgstat_count_io_op_time(). IIUC, what matters there is whether timing
> was on when the start time was captured, not what it is at reporting
> time. Looking at that, I would prefer reporting the remaining
> accumulated time here too to make it complete.
Fair enough.
I guess this also fits better with the existing comment.
```
/* Report any remaining cost-based vacuum delay time */
```
> Also, +1 to rename track_delay_timing to GUC name.
Done.
v2 attached.
--
Sami
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Propagate-track_cost_delay_timing-to-parallel-aut.patch | application/octet-stream | 4.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2026-09-29 04:21:10 | Re: Add counted_by attribute |
| Previous Message | Denis Smirnov | 2026-09-29 04:07:18 | Re: Fold NOT IN / <> ALL expressions containing NULL to FALSE |