| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove an unnecessary errmsg_plural in dependency.c |
| Date: | 2022-03-24 12:48:38 |
| Message-ID: | CALj2ACW_55LoOiHfAeakeOnot5ZjYfXa7thRSGnK+ACDM9eF9Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 24, 2022 at 2:34 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 24 Mar 2022, at 06:17, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> > The comment and errmsg_plural don't seem to be consistent. When the
> > code was added by c4f2a0458d, it had only singular form and already
> > had the comment. After that 8032d76b5 turned it to errmsg_plural
> > ignoring the comment. It seems like a thinko of 8032d76b5.
>
> Following the bouncing ball, that seems like a reasonable conclusion, and
> removing the plural form should be fine to reduce translator work.
Yes, the singular version of the message isn't required at all as
numReportedClient > 1. Hence I proposed to remove errmsg_plural and
singular version.
Regards,
Bharath Rupireddy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-03-24 13:00:05 | Re: multithreaded zstd backup compression for client and server |
| Previous Message | Daniel Gustafsson | 2022-03-24 12:44:51 | Re: TAP output format in pg_regress |