| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Remove an unnecessary errmsg_plural in dependency.c |
| Date: | 2022-03-24 09:04:28 |
| Message-ID: | 2F0B7A44-F67C-4845-AF3D-668FB4248A1D@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 24 Mar 2022, at 06:17, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> The comment and errmsg_plural don't seem to be consistent. When the
> code was added by c4f2a0458d, it had only singular form and already
> had the comment. After that 8032d76b5 turned it to errmsg_plural
> ignoring the comment. It seems like a thinko of 8032d76b5.
Following the bouncing ball, that seems like a reasonable conclusion, and
removing the plural form should be fine to reduce translator work.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2022-03-24 09:32:29 | Re: pg_walinspect - a new extension to get raw WAL data and WAL stats |
| Previous Message | Thomas Munro | 2022-03-24 08:50:34 | Re: [PATCH] add relation and block-level filtering to pg_waldump |