| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included |
| Date: | 2022-01-30 13:22:48 |
| Message-ID: | CALj2ACWVhxvUjp84a1Ng-Z05cPK0HmsY8Q8DW8LaQFdpLrsbbA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 30, 2022 at 1:07 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2022-Jan-29, Bharath Rupireddy wrote:
>
> > Removing the xloginsert.h in xlog.h would need us to add xloginsert.h
> > in more areas.
>
> Sure.
>
> > And also, it might break any non-core extensions that
> > includes just xlog.h and gets xloginsert.h.
>
> That's a pretty easy fix anyway -- it's not even version-specific, since
> the fix would work with the older versions. It's not something that
> would break on a minor version, either.
Here's the v3 patch removing xloginsert.h from xlog.h and adding
xloginsert.h in the required files.
Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-remove-xloginsert.h-from-xlog.h.patch | application/x-patch | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-01-30 14:49:12 | Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included |
| Previous Message | Pavel Stehule | 2022-01-30 13:15:31 | Re: Schema variables - new implementation for Postgres 15 |