Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included
Date: 2022-01-30 14:49:12
Message-ID: 20220130144912.gbhjum4yhrcjz4j6@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Sun, Jan 30, 2022 at 06:52:48PM +0530, Bharath Rupireddy wrote:
>
> Here's the v3 patch removing xloginsert.h from xlog.h and adding
> xloginsert.h in the required files.

+1, this approach is better. In general it's better to increase the number of
include lines rather than having a few that includes everything, for
compilation performance.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-01-30 15:27:11 Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included
Previous Message Bharath Rupireddy 2022-01-30 13:22:48 Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included