Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages
Date: 2022-07-20 11:55:33
Message-ID: CALj2ACW8YwHiCr5PqvW8625Wx1ZaaVumHY-uzS1JDabvbrgVCw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 20, 2022 at 12:55 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> At Wed, 20 Jul 2022 10:02:22 +0530, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote in
> > Done. PSA v6 patch set.
>
> Thanks!
>
> - Specifies the minimum size of past log file segments kept in the
> + Specifies the minimum size of past WAL files kept in the
>
> - log file by reducing the value of this parameter. On a system with
> + file by reducing the value of this parameter. On a system with
>
> Looks fine. And postgresq.conf.sample has the following lines:
>
> #archive_library = '' # library to use to archive a logfile segment
>
> #archive_command = '' # command to use to archive a logfile segment
>
> #archive_timeout = 0 # force a logfile segment switch after this
>
> #restore_command = '' # command to use to restore an archived logfile segment
>
> Aren't they need the same fix?

Indeed. Thanks. Now, they are in sync with their peers in .conf.sample
file as well as description in guc.c.

PSA v7 patch set.

Regards,
Bharath Rupireddy.

Attachment Content-Type Size
v7-0001-Use-WAL-segment-instead-of-log-segment.patch application/octet-stream 9.0 KB
v7-0002-Consistently-use-WAL-file-s-in-docs.patch application/octet-stream 20.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2022-07-20 12:27:07 Re: Allowing REINDEX to have an optional name
Previous Message Thomas Munro 2022-07-20 11:44:04 Re: Windows default locale vs initdb