| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Bernd Helmle <mailings(at)oopsware(dot)de>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Subject: | Re: Allowing REINDEX to have an optional name |
| Date: | 2022-07-20 12:27:07 |
| Message-ID: | 20220720122707.GI12702@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 19, 2022 at 01:13:34PM +0900, Michael Paquier wrote:
> > It looks like you named the table "toast_relfilenodes", but then also store
> > to it data for non-toast tables.
>
> How about naming that index_relfilenodes? One difference with what I
> posted previously and 5fb5b6 is the addition of an extra regclass that
> stores the parent table, for reference in the output.
Looks fine
> - 'CREATE TABLE toast_relfilenodes (parent regclass, indname regclass, relfilenode oid);'
> + 'CREATE TABLE index_relfilenodes (parent regclass, indname regclass, relfilenode oid);'
--
Justi
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2022-07-20 12:28:26 | RE: Support logical replication of DDLs |
| Previous Message | Bharath Rupireddy | 2022-07-20 11:55:33 | Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages |