| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Further cleanup related to statistics import support in postgres_fdw |
| Date: | 2026-08-22 20:57:00 |
| Message-ID: | CALj2ACVhebNitYJkz-bHFUWYqR7fW=ZLFV1rGcpz7m3DFmQVzQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Sat, Aug 22, 2026 at 3:26 AM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>
> > The changes look good to me. pgindent wasn't happy about one thing
> > [1], make check-world is fine (except a known issue in postgres_fdw
> > being discussed in [2]).
>
> Thanks for looking! I fixed the indentation. Attached is an updated
> patch for that.
>
> > I think this also needs to be backpatched (unless others think
> > otherwise) because this code is new in PG19 and it's better to keep
> > the version diff to a minimum.
>
> Agreed. I will push/backpatch the patch if no objections from others.
V3 patch LGTM. Thanks.
--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-08-22 21:38:58 | Re: Thread-safe stringToNode() / pg_strtok() |
| Previous Message | Andrei Lepikhov | 2026-08-22 20:33:15 | Re: Allow a prosupport function to be attached to an aggregate |