| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Jeff Davis <pgsql(at)j-davis(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Combine pg_walinspect till_end_of_wal functions with others |
| Date: | 2023-03-16 07:47:59 |
| Message-ID: | CALj2ACVaoXW3nJD9zq8E66BEf-phgJfFcKRVJq9GXkuX0b3ULQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 16, 2023 at 12:48 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Mar 15, 2023 at 06:50:01PM +0900, Michael Paquier wrote:
> > This is a duplicate of what describe.c uses, with a COLLATE clause.
> > The main goal was to have a simple check, so I'd still stand by the
> > simplest choice and move on.
>
> Please note that I have done something about that with e643a31 by
> replacing the problematic \dx with a SELECT query, but left the second
> one as it should not be a problem.
Thanks.
FWIW, I rebased the tests tweaking patch and attached it here as v9.
This should keep the pg_walinspect tests consistent across comments,
spaces, new lines and using count(*) >= 1 for all successful function
executions. Thoughts?
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-Tweak-pg_walinspect-tests-to-be-consistent.patch | application/octet-stream | 13.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2023-03-16 08:10:42 | Re: "current directory" in a server error message |
| Previous Message | Michael Paquier | 2023-03-16 07:40:33 | Remove last traces of SCM credential auth from libpq? |