Re: "current directory" in a server error message

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: bharath(dot)rupireddyforpostgres(at)gmail(dot)com
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: "current directory" in a server error message
Date: 2023-03-16 08:10:42
Message-ID: 20230316.171042.100484866638017773.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Thu, 16 Mar 2023 09:32:05 +0530, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote in
> On Thu, Mar 16, 2023 at 7:47 AM Kyotaro Horiguchi
> <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> > Thus I think that the message should read "path must be in or below
> > the data directory" instead.
> >
> > What do you think about making this change?
>
> Well yes. As far as postgres processes are concerned their working
> directory is set to data directory by the postmaster in
> ChangeToDataDir() and all the children will inherit that setting. So,
> I see nothing wrong in being explicit about it in the error messages.

Yeah, you're right.

> BTW, adminpack too has the same error message.

I somehow dropped them. Thanks for pointing.

> FWIW, here are the steps to generate the error:
> create role foo with nosuperuser;
> grant execute on function pg_ls_dir(text) to foo;
> set role foo;
> select * from pg_ls_dir('..');

Oh, thank you for the clarification about the reproduction method.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-03-16 08:45:11 Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Previous Message Bharath Rupireddy 2023-03-16 07:47:59 Re: Combine pg_walinspect till_end_of_wal functions with others