| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes |
| Date: | 2021-11-28 13:44:49 |
| Message-ID: | CALj2ACVZdBMhAOOZ1Fy-1zrxqT5bZoM8USWyGtCWZsWUpTtG+g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 28, 2021 at 5:21 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> Thanks for the updated patch, one comment:
> 1) The function can be indented similar to other functions in the same file:
> +CREATE FUNCTION memcxt_get_proc_pid(text)
> +RETURNS int
> +LANGUAGE SQL
> +AS 'SELECT pid FROM pg_stat_activity WHERE backend_type = $1';
>
> Something like:
> +CREATE FUNCTION memcxt_get_proc_pid(text)
> + RETURNS int
> + LANGUAGE SQL
> + AS 'SELECT pid FROM pg_stat_activity WHERE backend_type = $1';
Done. PSA v6 patch.
Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-enhance-pg_log_backend_memory_contexts-to-log-mem.patch | application/octet-stream | 10.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sasasu | 2021-11-28 15:37:18 | [PATCH] buffile: ensure start offset is aligned with BLCKSZ |
| Previous Message | vignesh C | 2021-11-28 11:51:35 | Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes |