From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes |
Date: | 2021-11-29 02:44:19 |
Message-ID: | CALDaNm1T8b7uXd-Dftt=UqNWOwB-JDT+n=zZ9yAc3o8GGQ7gZA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Nov 28, 2021 at 7:15 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Sun, Nov 28, 2021 at 5:21 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > Thanks for the updated patch, one comment:
> > 1) The function can be indented similar to other functions in the same file:
> > +CREATE FUNCTION memcxt_get_proc_pid(text)
> > +RETURNS int
> > +LANGUAGE SQL
> > +AS 'SELECT pid FROM pg_stat_activity WHERE backend_type = $1';
> >
> > Something like:
> > +CREATE FUNCTION memcxt_get_proc_pid(text)
> > + RETURNS int
> > + LANGUAGE SQL
> > + AS 'SELECT pid FROM pg_stat_activity WHERE backend_type = $1';
>
> Done. PSA v6 patch.
Thanks for the updated patch. The patch applies neatly, make
check-world passes and the documentation looks good. I did not find
any issues with the v6 patch, I'm marking the patch as Ready for
Committer.
Regards,
Vignesh
From | Date | Subject | |
---|---|---|---|
Next Message | houzj.fnst@fujitsu.com | 2021-11-29 02:54:45 | RE: row filtering for logical replication |
Previous Message | Tom Lane | 2021-11-29 02:40:41 | Re: rand48 replacement |