Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

On Sun, Nov 28, 2021 at 12:25 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Sun, Nov 28, 2021 at 12:22 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > > Attaching v4 patch, please review it further.
> >
> > One small comment:
> > 1) There should be a space in between "<literal>LOG</literal>message level"
> > + it can) for memory contexts. These memory contexts will be logged at
> > + <literal>LOG</literal>message level. They will appear in the server log
> > + based on the log configuration set (See <xref
> > linkend="runtime-config-logging"/>
> > + for more information), but will not be sent to the client regardless of
>
> Done.
>
> > The rest of the patch looks good to me.
>
> Thanks for the review. Here's the v5 patch.

Thanks for the updated patch, one comment:
1) The function can be indented similar to other functions in the same file:
+CREATE FUNCTION memcxt_get_proc_pid(text)
+RETURNS int
+LANGUAGE SQL
+AS 'SELECT pid FROM pg_stat_activity WHERE backend_type = $1';

Something like:
+CREATE FUNCTION memcxt_get_proc_pid(text)
+ RETURNS int
+ LANGUAGE SQL
+ AS 'SELECT pid FROM pg_stat_activity WHERE backend_type = $1';

Regards,
Vignesh