| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_receivewal: remove extra conn = NULL; in StreamLog |
| Date: | 2021-09-01 08:58:12 |
| Message-ID: | CALj2ACVWVb-W1gV9mvLRpENGdJ1rX7RrKBc81hLMfN_ooYqPFw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Aug 29, 2021 at 1:27 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 28 Aug 2021, at 14:10, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> > It seems there's a redundant assignment statement conn = NULL in
> > pg_receivewal's StreamLog function. Attaching a tiny patch herewith.
> > Thoughts?
>
> Agreed, while harmless this is superfluous since conn is already set to NULL
> after the PQfinish call a few lines up (which was added in a4205fa00d526c3).
> Unless there are objections I’ll apply this tomorrow or Monday.
Thanks for picking this up. I added this to CF to not lose it in the
wild - https://commitfest.postgresql.org/34/3317/
Regards,
Bharath Rupireddy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | REIX, Tony | 2021-09-01 08:59:57 | RE: AIX: Symbols are missing in libpq.a |
| Previous Message | Peter Eisentraut | 2021-09-01 08:57:20 | Re: Kerberos delegation support in libpq and postgres_fdw |