Re: pg_receivewal: remove extra conn = NULL; in StreamLog

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_receivewal: remove extra conn = NULL; in StreamLog
Date: 2021-08-28 19:57:51
Message-ID: 0C844850-3F65-4558-B3CB-8D0C29C387B9@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 28 Aug 2021, at 14:10, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:

> It seems there's a redundant assignment statement conn = NULL in
> pg_receivewal's StreamLog function. Attaching a tiny patch herewith.
> Thoughts?

Agreed, while harmless this is superfluous since conn is already set to NULL
after the PQfinish call a few lines up (which was added in a4205fa00d526c3).
Unless there are objections I’ll apply this tomorrow or Monday.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2021-08-28 20:03:41 Re: Autovacuum on partitioned table (autoanalyze)
Previous Message Tom Lane 2021-08-28 19:48:21 Re: extended stats objects are the only thing written like "%s"."%s"