Re: CREATE COLLATION - check for duplicate options and error out if found one

On Thu, May 27, 2021 at 8:36 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Wed, May 26, 2021 at 7:44 PM Bharath Rupireddy
> <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> >
> > On Wed, May 26, 2021 at 7:18 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > > +1 for fixing this issue, we have handled this error in other places.
> > > The patch does not apply on head, could you rebase the patch on head
> > > and post a new patch.
> >
> > Thanks. I thought of rebasing once the other patch (which reorganizes
> > "...specified more than once" error) gets committed. Anyways, I've
> > rebased for now on the latest master. Please review v2 patch.
>
> The test changes look good to me, I liked the idea of rebasing the
> source changes once "specified more than once" patch gets committed. I
> will review the code changes after that.

I'm not sure which patch goes first. I think the review can be
finished and see which one will be picked up first by the committer.
Based on that, the other patch can be rebased.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com