| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: CREATE COLLATION - check for duplicate options and error out if found one |
| Date: | 2021-05-27 15:06:30 |
| Message-ID: | CALDaNm2-WCDMx7nYjLh2H3p2urYY8VSyoG7baaLexCK8dbsbgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 26, 2021 at 7:44 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Wed, May 26, 2021 at 7:18 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > +1 for fixing this issue, we have handled this error in other places.
> > The patch does not apply on head, could you rebase the patch on head
> > and post a new patch.
>
> Thanks. I thought of rebasing once the other patch (which reorganizes
> "...specified more than once" error) gets committed. Anyways, I've
> rebased for now on the latest master. Please review v2 patch.
The test changes look good to me, I liked the idea of rebasing the
source changes once "specified more than once" patch gets committed. I
will review the code changes after that.
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2021-05-27 15:10:00 | Re: storing an explicit nonce |
| Previous Message | Bruce Momjian | 2021-05-27 14:57:24 | Re: storing an explicit nonce |