| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Performance Improvement For Copy From Binary Files |
| Date: | 2020-07-13 11:34:45 |
| Message-ID: | CALj2ACUNRQCXrqJAo-O2BhE3=nTbVqWSnR3GZ-8iCLKAkhXsiw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> > > CopyReadFromRawBuf as a name for the new function might be misleading
> > > as long as we are only using it for binary data. Maybe
> > > CopyReadBinaryData is more appropriate? See attached v4 with these
> > > and a few other cosmetic changes.
> > >
> >
> > CopyReadBinaryData() looks meaningful. +1.
>
> Okay, thanks. Let's have a committer take a look at this then?
>
I think yes, unless someone has any more points/review comments.
Accordingly the status in the commitfest can be changed.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-07-13 11:51:42 | Re: Default setting for enable_hashagg_disk |
| Previous Message | Amit Kapila | 2020-07-13 11:23:00 | Re: Resetting spilled txn statistics in pg_stat_replication |