Re: [PATCH] Performance Improvement For Copy From Binary Files

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Performance Improvement For Copy From Binary Files
Date: 2020-07-13 07:34:46
Message-ID: CA+HiwqE3RwGpnQzJfbS=TktWCH39HG+530T=C=Bbpa7CVAg2zQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 13, 2020 at 12:17 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> > CopyReadFromRawBuf as a name for the new function might be misleading
> > as long as we are only using it for binary data. Maybe
> > CopyReadBinaryData is more appropriate? See attached v4 with these
> > and a few other cosmetic changes.
> >
>
> CopyReadBinaryData() looks meaningful. +1.

Okay, thanks. Let's have a committer take a look at this then?

--
Amit Langote
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2020-07-13 07:40:25 Re: OpenSSL 3.0.0 compatibility
Previous Message Kyotaro Horiguchi 2020-07-13 07:01:11 Re: max_slot_wal_keep_size and wal_keep_segments