Simplify backtrace_functions GUC code

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Simplify backtrace_functions GUC code
Date: 2024-03-17 06:31:00
Message-ID: CALj2ACUKXyzExNYeHamygL93G8fJspOtxUHYQvvvUNf5bHC9qA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While working on [1], I noticed that the backtrace_functions GUC code
does its own string parsing and uses another extra variable
backtrace_function_list to store the processed form of
backtrace_functions GUC.

I think the code can be simplified a bit by using
SplitIdentifierString like in the attached patch. With this,
backtrace_function_list variable and assign_backtrace_functions() will
go away.

Thoughts?

[1] https://www.postgresql.org/message-id/CALj2ACXG1wzrb8%2B5HPNd8Qjr1h8GYkW-ijWhMYr2Y8_DzOB-%3Dg%40mail.gmail.com

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v1-0001-Simplify-backtrace_functions-GUC-code.patch application/x-patch 5.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2024-03-17 06:53:10 Re: Confine vacuum skip logic to lazy_scan_skip
Previous Message Peter Eisentraut 2024-03-17 06:12:19 Re: clarify equalTupleDescs()