| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation |
| Date: | 2021-11-15 09:38:26 |
| Message-ID: | CALj2ACU=eLF9KHTcaK6uhr5RpdBA2ZSk_5SMJR_0hhnhyEe3bQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 15, 2021 at 2:14 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 15 Nov 2021, at 09:15, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> > I think this is not an improvement. It loses the ability of the caller the
> > specify exactly why a relation is not acceptable.
>
>
> Agreed.
+1.
> > I think a separate errdetail_relpersistence_not_supported() would be a better
> > solution (assuming there are enough callers to make it worth a separate
> > function).
>
>
> I still think that the v8 patch posted earlier is the better option, which
> increase granularity of error reporting with a small code footprint.
Thanks. Attaching the v8 here again.
Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Improve-publication-error-messages.patch | application/octet-stream | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2021-11-15 09:42:21 | Re: row filtering for logical replication |
| Previous Message | Amit Kapila | 2021-11-15 09:36:54 | Re: row filtering for logical replication |