Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation
Date: 2021-11-15 08:44:28
Message-ID: 3DE4CBB6-7C3B-4A99-AFFB-5B40AD48CBF0@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 15 Nov 2021, at 09:15, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:

> I think this is not an improvement. It loses the ability of the caller the
> specify exactly why a relation is not acceptable.

Agreed.

> I think a separate errdetail_relpersistence_not_supported() would be a better
> solution (assuming there are enough callers to make it worth a separate
> function).

I still think that the v8 patch posted earlier is the better option, which
increase granularity of error reporting with a small code footprint.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-11-15 09:14:24 Re: row filtering for logical replication
Previous Message Masahiko Sawada 2021-11-15 08:30:59 Re: parallel vacuum comments