Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Euler Taveira <euler(at)eulerto(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation
Date: 2021-11-15 18:42:41
Message-ID: f79c6631-ca02-6c4a-e70b-17e8bf96cef3@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 15.11.21 10:38, Bharath Rupireddy wrote:
>> I still think that the v8 patch posted earlier is the better option, which
>> increase granularity of error reporting with a small code footprint.
> Thanks. Attaching the v8 here again.

I find the use of RelationUsesLocalBuffers() confusing in this patch.
It would be clearer to check relpersistence directly in both branches of
the if statement.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dagfinn Ilmari Mannsåker 2021-11-15 18:42:53 Re: Test::More version
Previous Message Andres Freund 2021-11-15 18:34:15 Re: [RFC] building postgres with meson