From: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Calling PrepareTempTablespaces in BufFileCreateTemp |
Date: | 2019-04-29 19:31:38 |
Message-ID: | CALfoeitwQ5kOhZC2EHK1tP6mNAon17cCO7nPRk07BRzcfrpX8Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Apr 25, 2019 at 11:53 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Apr 25, 2019 at 12:45:03PM -0400, Tom Lane wrote:
> > I still remain concerned that invoking catalog lookups from fd.c is a darn
> > bad idea, even if we have a fallback for it to work (for some value of
> > "work") in non-transactional states. It's not really hard to envision
> > that kind of thing leading to infinite recursion. I think it's safe
> > right now, because catalog fetches shouldn't lead to any temp-file
> > access, but that's sort of a rickety assumption isn't it?
>
> Introducing catalog lookups into fd.c which is not a layer designed
> for that is a choice that I find strange, and I fear that it may bite
> in the future. I think that the choice proposed upthread to add
> an assertion on TempTablespacesAreSet() when calling a function
> working on temporary data is just but fine, and that we should just
> make sure that the gist code calls PrepareTempTablespaces()
> correctly. So [1] is a proposal I find much more acceptable than the
> other one.
Well the one thing I wish to point out explicitly is just taking fd.c
changes from [1], and running make check hits no assertions and
doesn't flag issue exist for gistbuildbuffers.c. Means its missing
coverage and in future same can happen as well.
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2019-04-29 19:35:22 | Re: Calling PrepareTempTablespaces in BufFileCreateTemp |
Previous Message | Chapman Flack | 2019-04-29 19:19:02 | Re: generate documentation keywords table automatically |