| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Calling PrepareTempTablespaces in BufFileCreateTemp |
| Date: | 2019-04-29 19:35:22 |
| Message-ID: | CAH2-WznQTs9fPWuCZ5aUMAK+MMTZqhLOpMHKFgxAcgOCpO5v6w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 29, 2019 at 12:31 PM Ashwin Agrawal <aagrawal(at)pivotal(dot)io> wrote:
> Well the one thing I wish to point out explicitly is just taking fd.c
> changes from [1], and running make check hits no assertions and
> doesn't flag issue exist for gistbuildbuffers.c. Means its missing
> coverage and in future same can happen as well.
I believe that the test coverage of GiST index builds is something
that is being actively worked on right now. It's a recognized problem
[1].
[1] https://postgr.es/m/24954.1556130678@sss.pgh.pa.us
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2019-04-29 19:39:06 | Re: [PATCH v4] Add \warn to psql |
| Previous Message | Ashwin Agrawal | 2019-04-29 19:31:38 | Re: Calling PrepareTempTablespaces in BufFileCreateTemp |