| From: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Asim R P <apraveen(at)pivotal(dot)io>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Subject: | Re: Pluggable Storage - Andres's take |
| Date: | 2019-03-06 02:27:45 |
| Message-ID: | CALfoeis=ha=oyqHoBd0vqBpi+7pgyBmyh89ABbvWmS00wBgz8w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
While playing with the tableam, usage of which starts with commit
v12-0023-tableam-Introduce-and-use-begin-endscan-and-do-i.patch, should we
check for NULL function pointer before actually calling the same and ERROR
out instead as NOT_SUPPORTED or something on those lines.
Understand its kind of think which should get caught during development.
But still currently it segfaults if missing to define some AM function,
might be easier for iterative development to error instead in common place.
Or should there be upfront check for NULL somewhere if all the AM functions
are mandatory to have functions defined for them and should not be NULL.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2019-03-06 02:29:44 | Re: Update does not move row across foreign partitions in v11 |
| Previous Message | Michael Paquier | 2019-03-06 02:27:38 | Re: Patch to document base64 encoding |