Re: remove unnecessary include in src/backend/commands/policy.c

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: remove unnecessary include in src/backend/commands/policy.c
Date: 2026-01-03 19:47:23
Message-ID: CALdSSPj7U-eqAQb2XOBEQfoJFsnMQHa=MwcMEpiEkNUrhDoCUg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 26 Dec 2025 at 14:29, Japin Li <japinli(at)hotmail(dot)com> wrote:
>
>
> Hi, Shinya
>
> On Fri, 26 Dec 2025 at 16:30, Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
> > On Wed, Oct 22, 2025 at 3:30 PM Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
> >> Thank you for updating the patch.
> >> But I said "except for access/relation.h". I think access/relation.h
> >> is not necessary if you replace relation_open to table_open.
> >
> > I've fixed it, and marked the patch as Ready for Committer.
> >
>
> Found a typo in the commit message.
>
> > RangeVarCallbackForPolicy already ensures policies apply only to tables
> > or partitioned tables, so table_* isthe appropriate API for
> > opening/closing the target relation.
>
> s/isthe/is the/
>
>
> --
> Regards,
> Japin Li
> ChengDu WenWu Information Technology Co., Ltd.
>
>

Hi hackers!

We also can reflect that our new coding practice is to use table/index
open over relation_open in the commit message (I guess so after[0]).

Overall LGTM.

[0] https://git.postgresql.org/cgit/postgresql.git/commit/?id=9d0f7996e58c2a92efe06c901c6dfe1f6ced0a1d

--
Best regards,
Kirill Reshke

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2026-01-03 20:00:05 Re: [Patch]Add tab completion for DELETE ... USING
Previous Message Kirill Reshke 2026-01-03 19:33:56 Re: [PATCH] psql: add size-based sorting options (O/o) for tables and indexes