| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Roman Khapov <rkhapov(at)yandex-team(dot)ru> |
| Subject: | Re: GIN pageinspect support for entry tree and posting tree |
| Date: | 2026-01-10 14:17:06 |
| Message-ID: | CALdSSPj-ADRgBk1_gspb2Q0eY2wxQHLfiWfFOmAwSxMF_AboRQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 10 Jan 2026 at 17:15, Japin Li <japinli(at)hotmail(dot)com> wrote:
> > Your comments refer to v12-0002. For the record, did you review 0001,
> > if yes, do you think it is good? I have included you as a reviewer to
> > v12-0002 commit message.
> >
>
> Yeah, patch 0001 looks good to me.
Thank you. I have updated 0001 commit message.
>
> I noticed that the IS_INDEX macro is currently defined in btreefunc.c,
> hashfuncs.c, and now also in ginfuncs.c. Would it be possible to move it
> to a shared header file so all these modules can include it from one place?
>
This is something I had thought about also. I do find this idea good,
but 0002 patch is already big, and I don't want to overload it. So,
v14-0004 with this change attached.
--
Best regards,
Kirill Reshke
| Attachment | Content-Type | Size |
|---|---|---|
| v14-0001-Modernize-coding-in-GIN-pageinspect-functions.patch | application/octet-stream | 5.4 KB |
| v14-0002-GIN-pageinspect-support-for-entry-tree-and-posti.patch | application/octet-stream | 30.1 KB |
| v14-0003-Move-IS_INDEX-macro-to-pageinspect.h.patch | application/octet-stream | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2026-01-10 14:34:16 | Re: Maybe BF "timedout" failures are the client script's fault? |
| Previous Message | Dilip Kumar | 2026-01-10 13:15:28 | Re: Proposal: Conflict log history table for Logical Replication |