Re: Use IsA() macro instead of nodeTag comparison

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use IsA() macro instead of nodeTag comparison
Date: 2026-01-08 13:10:44
Message-ID: CALdSSPi5fWXfby+B+rpT--zuazGhmBd3Bg1L3VGDCpabeRYGFw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 8 Jan 2026 at 17:31, Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
>
> Hi hackers,

Hi

> In copy.c, nodeTag was being compared directly, so I replaced it with
> the IsA() predicate macro for consistency.

Oops. Looks like oversight in 6c8f670. This is indeed case where we
should use IsA()

> I verified that there are no other direct comparisons left by running
> the following command:
> $ git grep "nodeTag(.*) =="

Yep, look like this is the only case in copy.c

> --
> Best regards,
> Shinya Kato
> NTT OSS Center

--
Best regards,
Kirill Reshke

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2026-01-08 13:30:11 Re: Fwd: pg18 bug? SELECT query doesn't work
Previous Message Chao Li 2026-01-08 13:02:11 Re: Refactor replication origin state reset helpers