Re: Use IsA() macro instead of nodeTag comparison

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>, Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use IsA() macro instead of nodeTag comparison
Date: 2026-01-08 17:11:29
Message-ID: 84cdb63c-b4cd-457f-812f-d32c062d5b0b@iki.fi
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08/01/2026 15:10, Kirill Reshke wrote:
> On Thu, 8 Jan 2026 at 17:31, Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
>> In copy.c, nodeTag was being compared directly, so I replaced it with
>> the IsA() predicate macro for consistency.
>
> Oops. Looks like oversight in 6c8f670. This is indeed case where we
> should use IsA()
>
>> I verified that there are no other direct comparisons left by running
>> the following command:
>> $ git grep "nodeTag(.*) =="
>
> Yep, look like this is the only case in copy.c

Pushed, thanks

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2026-01-08 17:11:40 Re: GIN pageinspect support for entry tree and posting tree
Previous Message Antonin Houska 2026-01-08 16:59:00 Re: Adding REPACK [concurrently]