Re: reconsider_full_join_clause fails to consider if COALESCE() arguments are NULL-preserving

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Tomas Vondra <tomas(at)vondra(dot)me>
Cc: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: reconsider_full_join_clause fails to consider if COALESCE() arguments are NULL-preserving
Date: 2026-11-12 15:18:08
Message-ID: CALdSSPhSb2SZN3dLgGtHXZ=46quy98DnehjZn8mGpUcx=0CQGg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 12 Nov 2026 at 17:57, Tomas Vondra <tomas(at)vondra(dot)me> wrote:
>
> On 11/12/26 11:28, Tomas Vondra wrote:
> >
> > ...
> >
> > I suppose an expression walker that does not descend into PlaceHolderVar
> > nodes (with phlevelsup = 0) would make this work correctly.
> >
> Here's v3 doing it that way.
>
> --
> Tomas Vondra

v3 looks totally fine for me, perf regressions from my report
eliminated - good.
There are maybe some more cases to recurce, but we shouldn't defer
this bugs fix commit because of this. LGTM

--
Best regards,
Kirill Reshke

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message 신성준 2026-11-12 15:23:52 Re: Add wait events for server logging destination writes
Previous Message Tom Lane 2026-11-12 15:17:33 Re: SIGFPE handling