| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | "denni(dot)pat" <denni(dot)pat(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted |
| Date: | 2020-11-11 14:13:13 |
| Message-ID: | CALT9ZEGD_QdW2n2_R5vhuxAES5OtvEdiZcp9QQBrPk298mwntA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Thomas,
I get into the patch and I think it's worth being committed and
backpatched.
BTW I noticed that sometimes the same comparisons are done twice, and I
made a very minor refactor of the code. PFA v2 of a patch if you don't mind.
As for the question on what to do with the additional segments if the first
one failed to be truncated, I don't consider myself experienced enough and
surely someone else's independent opinion is very much welcome.
--
Best regards,
Pavel Borisov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Free-disk-space-for-dropped-relations-on-commit.patch | application/octet-stream | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-11-11 14:56:50 | Re: pg should ignore u+200b zero width space |
| Previous Message | Kurt Roeckx | 2020-11-11 12:14:20 | Re: BUG #16707: Memory leak |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Victor Yegorov | 2020-11-11 14:17:32 | Re: Deleting older versions in unique indexes to avoid page splits |
| Previous Message | Bharath Rupireddy | 2020-11-11 14:01:49 | Re: Skip ExecCheckRTPerms in CTAS with no data |