| From: | Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted |
| Date: | 2020-11-19 08:20:18 |
| Message-ID: | 160577401827.18283.12544488614854285060.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
Hi, I have tested the feature and it worked well.
One thing that doesn't matter is that the modify here seems unnecessary, right?
> mdunlinkfork(RelFileNodeBackend rnode, ForkNumber forkNum, bool isRedo)
> {
> char *path;
> - int ret;
> + int ret = 0;
> path = relpath(rnode, forkNum
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-11-19 13:31:35 | Re: BUG #16726: Invalid input syntax is not a useful error message |
| Previous Message | Andres Freund | 2020-11-19 01:40:43 | Re: BUG #16722: PG hanging on COPY when table has close to 2^32 toasts in the table. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniil Zakhlystov | 2020-11-19 08:26:59 | Re: libpq compression |
| Previous Message | Masahiro Ikeda | 2020-11-19 08:03:20 | Re: Add statistics to pg_stat_wal view for wal related parameter tuning |