naming of async_mode parameter

From: Zhihong Yu <zyu(at)yugabyte(dot)com>
To: efujita(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: naming of async_mode parameter
Date: 2021-05-12 17:27:01
Message-ID: CALNJ-vRM3vH24hv1i8R8h6+ocOib04wBYGycuuy_Jjo2j6S4CA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Etsuro-san:
I was looking at
Fix EXPLAIN ANALYZE for async-capable nodes.

which adds the following parameter / field:

+ bool async_mode; /* true if node is in async mode */

async_mode implies an enum: {sync, async}
Since there are only two values, the data type is bool. I think it should
be named is_async.

What do you think?

Cheers

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2021-05-12 17:39:39 Re: PG 14 release notes, first draft
Previous Message Bruce Momjian 2021-05-12 17:25:30 Re: PG 14 release notes, first draft