Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Dong Wook Lee <sh95119(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE
Date: 2022-11-22 06:18:58
Message-ID: CALDaNm3oLHTPJbtn3GQAQ+ki29HRf=JB3r6RfAN5u2ezn0N5Yw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 22 Nov 2022 at 05:59, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Oct 28, 2022 at 05:34:37PM +0530, vignesh C wrote:
> > Those also should be handled, attached v2 version includes the changes
> > for the same.
>
> The basic options supported by PROCEDURE are a subset of ROUTINE with a
> difference of COST, IMMUTABLE, [NOT] LEAKPROOF, ROWS, STABLE
> and VOLATILE.
>
> The basic options supported by ROUTINE are a subset of FUNCTION with a
> difference of { CALLED | RETURNS NULL } ON NULL INPUT, STRICT and
> SUPPORT. Is it worth refactoring a bit with common lists?

Modified

> + "RESET", "RETURNS NULL ON NULL INPUT ", "ROWS",
> Extra space after INPUT here, that's easy to miss.

Good catch, the attached v3 patch has the changes for the same.

Regards,
Vignesh

Attachment Content-Type Size
v3-0001-Tab-completion-for-ALTER-FUNCTION-PROCEDURE-ROUTI.patch text/x-patch 3.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-11-22 06:19:23 Re: Split index and table statistics into different types of stats
Previous Message Bagga, Rishu 2022-11-22 06:02:10 Re: SLRUs in the main buffer pool - Page Header definitions