Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE

From: Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Dong Wook Lee <sh95119(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE
Date: 2022-12-06 15:12:38
Message-ID: CAGPVpCTrRDho5xguMbsro-BhHoz94BLC52JXgzGWGPKFnTVcQg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Vignesh,

Looks like the patch needs a rebase.

Also one little suggestion:

+ if (ends_with(prev_wd, ')'))
> + COMPLETE_WITH(Alter_routine_options, "CALLED ON NULL INPUT",
> + "RETURNS NULL ON NULL INPUT", "STRICT", "SUPPORT");

What do you think about gathering FUNCTION options as you did with ROUTINE
options.
Something like the following would seem nicer, I think.

#define Alter_function_options \
> Alter_routine_options, "CALLED ON NULL INPUT", \

"RETURNS NULL ON NULL INPUT", "STRICT", "SUPPORT"

Best,
--
Melih Mutlu
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-12-06 15:19:05 Re: ExecRTCheckPerms() and many prunable partitions
Previous Message Alexander Korotkov 2022-12-06 15:00:54 Re: Allow placeholders in ALTER ROLE w/o superuser