Re: moving extraUpdatedCols out of RangeTblEntry (into ModifyTable)

On Thu, 8 Dec 2022 at 08:17, Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>
> On Wed, Dec 7, 2022 at 8:54 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > Per Alvaro's advice, forking this from [1].
> >
> > In that thread, Tom had asked if it wouldn't be better to find a new
> > place to put extraUpdatedCols [2] instead of RangeTblEntry, along with
> > the permission-checking fields are now no longer stored in
> > RangeTblEntry.
> >
> > In [3] of the same thread, I proposed to move it into a List of
> > Bitmapsets in ModifyTable, as implemented in the attached patch that I
> > had been posting to that thread.
> >
> > The latest version of that patch is attached herewith.
>
> Updated to replace a list_nth() with list_nth_node() and rewrote the
> commit message.

The patch does not apply on top of HEAD as in [1], please post a rebased patch:
=== Applying patches on top of PostgreSQL commit ID
e351f85418313e97c203c73181757a007dfda6d0 ===
=== applying patch
./v2-0001-Add-per-result-relation-extraUpdatedCols-to-Modif.patch
...
patching file src/backend/optimizer/util/inherit.c
Hunk #2 FAILED at 50.
Hunk #9 succeeded at 926 with fuzz 2 (offset -1 lines).
1 out of 9 hunks FAILED -- saving rejects to file
src/backend/optimizer/util/inherit.c.rej

[1] - http://cfbot.cputube.org/patch_41_4049.log

Regards,
Vignesh