Re: Distinguish publication exclusions in object addresses

On Tue, 15 Sept 2026 at 10:07, shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Sun, Sep 13, 2026 at 9:01 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> >
> > I preferred the single lookup approach. The
> > v1-0002-Review-comment-fixes.patch at [1] has the changes for the
> > same.
>
> Thanks Vignesh.
>
> Instead of isPublicationRelationExcept() with the exclusion logic
> outside and the fallback logic inside -- which is also not very clear:
>
> + /* fallback to a non-exclusion entry for an undefined object */
> + return false;
>
> I think we could introduce a function similar to
> getProcedureTypeDescription() and getConstraintTypeDescription().
> Please see the attached patch. Take the changes if you agree.

Your suggestion looks better, I have merged the proposed changes with
a couple of minor changes a) changed function name
getPublicationRelationDescription to
getPublicationRelationTypeDescription. This will keep it consistent by
having Type in the function name similar to
getConstraintTypeDescription, getProcedureTypeDescription and
getRelationTypeDescription. b) Changed "failed for publication
relation" to "failed for publication table" so that it is consistent
with other search sys cache failures of PUBLICATIONREL.

The attached v2 version patch has the changes for the same. This also
addresses Hou's comments from [1].

[1] - https://www.postgresql.org/message-id/TY4PR01MB1771860516F5316ECB8CD275494BB2%40TY4PR01MB17718.jpnprd01.prod.outlook.com

Regards,
Vignesh