Re: Distinguish publication exclusions in object addresses

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: Distinguish publication exclusions in object addresses
Date: 2026-09-15 04:36:57
Message-ID: CAJpy0uDacNouHQiPOvGZXP6Z_deQFpNAi8Z+nV00hn8Eg2R73w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Sep 13, 2026 at 9:01 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
>
> I preferred the single lookup approach. The
> v1-0002-Review-comment-fixes.patch at [1] has the changes for the
> same.

Thanks Vignesh.

Instead of isPublicationRelationExcept() with the exclusion logic
outside and the fallback logic inside -- which is also not very clear:

+ /* fallback to a non-exclusion entry for an undefined object */
+ return false;

I think we could introduce a function similar to
getProcedureTypeDescription() and getConstraintTypeDescription().
Please see the attached patch. Take the changes if you agree.

thanks
Shveta

Attachment Content-Type Size
0001-getPublicationRelationDescription-function.patch application/octet-stream 3.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message solai v 2026-09-15 04:44:39 Re: Convert ALL SubLinks to ANY SubLinks
Previous Message Bertrand Drouvot 2026-09-15 04:24:49 Re: Trying to break online checksums with LLMs