Re: Unused header file inclusion

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unused header file inclusion
Date: 2019-07-31 06:01:15
Message-ID: CALDaNm2shkzdA3M=KkrwW9GGYf79ZD9=zfOPHRWs=VXKVEectA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 31, 2019 at 11:26 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jul 31, 2019 at 11:19:08AM +0530, vignesh C wrote:
> > I noticed that there are many header files being included which need
> > not be included. I have tried this in a few files and found the
> > compilation and regression to be working. I have attached the patch
> > for the files that I tried. I tried this in CentOS, I did not find
> > the header files to be platform specific.
> > Should we pursue this further and cleanup in all the files?
>
> Do you use a particular method here or just manual deduction after
> looking at each file individually? If this can be cleaned up a bit, I
> think that's welcome. The removal of headers is easily forgotten when
> moving code from one file to another...
>
Thanks Michael.
I'm writing some perl scripts to identify this.
The script will scan through all the files, make changes,
and verify.
Finally it will give the changed files.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ning Yu 2019-07-31 06:02:03 Re: Possible race condition in pg_mkdir_p()?
Previous Message Michael Paquier 2019-07-31 05:56:30 Re: Unused header file inclusion