| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unused header file inclusion |
| Date: | 2019-07-31 05:56:30 |
| Message-ID: | 20190731055630.GO1577@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 31, 2019 at 11:19:08AM +0530, vignesh C wrote:
> I noticed that there are many header files being included which need
> not be included. I have tried this in a few files and found the
> compilation and regression to be working. I have attached the patch
> for the files that I tried. I tried this in CentOS, I did not find
> the header files to be platform specific.
> Should we pursue this further and cleanup in all the files?
Do you use a particular method here or just manual deduction after
looking at each file individually? If this can be cleaned up a bit, I
think that's welcome. The removal of headers is easily forgotten when
moving code from one file to another...
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2019-07-31 06:01:15 | Re: Unused header file inclusion |
| Previous Message | Takuma Hoshiai | 2019-07-31 05:52:31 | Re: Proposal to suppress errors thrown by to_reg*() |