Re: Fix publisher-side sequence permission reporting

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Tristan Partin <tristan(at)partin(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix publisher-side sequence permission reporting
Date: 2026-07-24 13:01:18
Message-ID: CALDaNm2nOUbF9+AuM6qDc8Fj=3MGWzuakxv9EJ6tGxQNebsu5Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 24 Jul 2026 at 14:23, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> So, isn't it clearer to describe this in terms of has_sequence_privilege()
> returning false rather than NULL? For example:
>
> /*
> * The publisher lacks the SELECT privilege required by
> * pg_get_sequence_data(). Since has_sequence_privilege() returned
> * false, not NULL, do not classify this sequence as missing on the
> * publisher.
> */

This is better, the updated v2 version has the changes for the same.

Regards,
Vignesh

Attachment Content-Type Size
v2-0001-Avoid-reporting-permission-denied-publisher-seque.patch application/octet-stream 2.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message wenhui qiu 2026-07-24 13:25:35 Re: [PATCH] Reduce LWLockWaitListLock() cache-line contention with adaptive spin reads
Previous Message Ashutosh Bapat 2026-07-24 12:58:40 Re: Better shared data structure management and resizable shared data structures