Re: Hash index: stop registering pin-only bucket pages in WAL (remove REGBUF_NO_CHANGE)

On Thu, 12 Nov 2026 at 21:43, Joao Rito <joaovictor(dot)rito(at)gmail(dot)com> wrote:
>
> Hi Greg,
>
> Thank you for the v7 patch and the new recovery test.
>
> I tested v7 on a local build. While running 061_hash_vacuum_insert_crc on
> Linux (ext4, meson build), subtest 2 failed for me with:y
>
> pg_waldump: error: invalid WAL segment size in WAL file
> "000000010000000000000002" (0 bytes)
>
> Both LSNs are in segment ...0001, and segment ...0002 is a zero-filled
> 16 MB file. When --path is a directory, pg_waldump seems to read the
> segment size from the first WAL file readdir() returns, so the result
> depends on directory order (here 0002 came first).
>
> Passing the segment file for $start_lsn (for example from pg_walfile_name)
> worked for me by hand. Subtest 3 passed and I saw no CRC problem. I did
> not apply the change to the test and rerun it under meson.

Thanks for the comment, this is addressed in the v8 version patch attached.
Apart from that, the following changes were done:
1) prepared back branch patches for the 0001 patch.
2) The test 068 was renamed to the next available 061 test file.
3) Most of the test code was common in
hash_torn_primary_page_delete_first and
hash_torn_primary_page_standby, merged them to a single test
4) the test added along with 0001 was not passing with the first patch
alone, fixed it so that the first patch can be committed separately.

Regards,
Vignesh