| From: | Joao Rito <joaovictor(dot)rito(at)gmail(dot)com> |
|---|---|
| To: | Greg Burd <greg(at)burd(dot)me> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, vignesh C <vignesh21(at)gmail(dot)com>, Hayato Kuroda <kuroda(dot)hayato(at)fujitsu(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com> |
| Subject: | Re: Hash index: stop registering pin-only bucket pages in WAL (remove REGBUF_NO_CHANGE) |
| Date: | 2026-11-12 16:12:57 |
| Message-ID: | 20261112161257.15876-1-joaovictor.rito@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Greg,
Thank you for the v7 patch and the new recovery test.
I tested v7 on a local build. While running 061_hash_vacuum_insert_crc on
Linux (ext4, meson build), subtest 2 failed for me with:
pg_waldump: error: invalid WAL segment size in WAL file
"000000010000000000000002" (0 bytes)
Both LSNs are in segment ...0001, and segment ...0002 is a zero-filled
16 MB file. When --path is a directory, pg_waldump seems to read the
segment size from the first WAL file readdir() returns, so the result
depends on directory order (here 0002 came first).
Passing the segment file for $start_lsn (for example from pg_walfile_name)
worked for me by hand. Subtest 3 passed and I saw no CRC problem. I did
not apply the change to the test and rerun it under meson.
Thanks again!
Regards,
Joao Rito
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Srinath Reddy Sadipiralla | 2026-11-12 16:28:04 | Re: pg_rewind: Remove recovery at the start of rewind |
| Previous Message | Joao Rito | 2026-11-12 16:12:43 | Re: pg_stat_io_histogram |