From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Reorderbuffer crash during recovery |
Date: | 2020-01-20 00:36:39 |
Message-ID: | CALDaNm1znUyu-QyLu0f-VH-nsbb4mYOQiCVujb7eJ37MD-+ZgA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Sat, Jan 18, 2020 at 2:42 AM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> On 2020-Jan-17, vignesh C wrote:
>
> > Thanks Dilip for reviewing.
> > I have fixed the comments you have suggested.
>
> I ended up rewording that comment completely; I thought the original was
> not explaining things well enough.
>
> I also changed the comment for final_lsn in reorderbuffer.h: not only I
> remove the line that I added in df9f682c7bf8 (the previous bugfix), but
> I also remove the line that says "error during decoding", which came in
> with the very first logical decoding commit (b89e151054a); I couldn't
> find any evidence that final_lsn is being set on errors of any kind
> (other than transaction abort, which doesn't seem an "error" in that
> sense.)
>
> Please give these comments a read; maybe I have misunderstood something
> and my comment is wrong.
>
> Pushed now to all branches. Thanks, Vignesh, Amit and Dilip.
>
Thanks Alvaro for pushing this patch.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-01-20 01:59:13 | Re: REINDEX CONCURRENTLY unexpectedly fails |
Previous Message | Michael Paquier | 2020-01-19 10:05:01 | Re: libpq parameter parsing problem |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-01-20 00:38:13 | Re: range_agg |
Previous Message | Ranier Vilela | 2020-01-20 00:35:44 | Re: [PATCH] src\backend\utils\adt\numeric.c copy and past error |