Re: [PATCH] src\backend\utils\adt\numeric.c copy and past error

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] src\backend\utils\adt\numeric.c copy and past error
Date: 2020-01-20 00:35:44
Message-ID: CAEudQAqYTg9h5E4zAWVC-tTKY=-4TsuXh=RP3zp5syY-nxTOUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
Yes, but the comment it does not clarify that the return of the variable
"const_one" is intentional, instead of "const_zero".
Anybody with reads the source, can think which is a copy and paste mistake.

regards
Ranier Vilela

Em dom., 19 de jan. de 2020 às 21:22, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> escreveu:

> Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> writes:
> > Possible copy and past error, found in numeric.c.
> > I believe I believe that the author's intention was to return const_zero.
>
> Did you read the comment just above there?
>
> regards, tom lane
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2020-01-20 00:36:39 Re: Reorderbuffer crash during recovery
Previous Message John Naylor 2020-01-20 00:27:41 Re: remove separate postgres.(sh)description files