Re: Review items for EXCEPT TABLE publication

From: vignesh C <vignesh21(at)gmail(dot)com>
To: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Review items for EXCEPT TABLE publication
Date: 2026-09-10 16:17:11
Message-ID: CALDaNm1_64PTi7=M6eyyB170T7onbrkkF73g_42KoRAiRZ0Afw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 10 Sept 2026 at 17:11, Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Vignesh,
>
> > Thanks kuroda-san. I have addressed this in the v2 version patch
> > attached, however I did not change the lock mode and used the existing
> > AccessShareLock mode itself as I felt that should suffice. This
> > approach also addresses Chao's comments from [1].
>
> My intention was similar but can we unify codes for re-validation?
> My idea attached here could be applied atop v2.

Thanks, this looks better. The attached v3 version incorporates these changes.
I have also addressed Amit's suggestion from [1] and the test comment
fixes from [2]. Additionally, the test changes have been consolidated
into a single v3-002 patch.

[1] - https://www.postgresql.org/message-id/CAA4eK1J-W2omce_%2BD%2BNn9syUA3DPOkKHyB1K24pXGCEpfksYkg%40mail.gmail.com
[2] - https://www.postgresql.org/message-id/OS9PR01MB12149C3E3EC7D9738644CEBD8F5BF2%40OS9PR01MB12149.jpnprd01.prod.outlook.com

Regards,
Vignesh

Attachment Content-Type Size
v3-0002-Improve-EXCEPT-publication-tests.patch application/octet-stream 3.0 KB
v3-0001-AlterPublication-revalidate-publication-after-acq.patch application/octet-stream 5.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2026-09-10 16:39:34 Re: pgstat: Flush some statistics within running transactions, take 2
Previous Message Tom Lane 2026-09-10 16:16:06 Re: Add PRODUCT() aggregate function